From 71a929a27e450f36cff615540440fe308d10ec21 Mon Sep 17 00:00:00 2001
From: adpth <adpth14@gmail.com>
Date: Thu, 15 Oct 2020 19:51:49 +0530
Subject: [PATCH] added ViewBinding & reduced no.of lines
---
app/build.gradle | 4 +
.../com/adpth/bmicalculator/MainActivity.java | 81 +++++++------------
2 files changed, 33 insertions(+), 52 deletions(-)
diff --git a/app/build.gradle b/app/build.gradle
index 67768b1..410800e 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -21,6 +21,10 @@ android {
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
}
}
+
+ buildFeatures {
+ viewBinding = true
+ }
}
dependencies {
diff --git a/app/src/main/java/com/adpth/bmicalculator/MainActivity.java b/app/src/main/java/com/adpth/bmicalculator/MainActivity.java
index 5c3ee92..9e44fd4 100644
--- a/app/src/main/java/com/adpth/bmicalculator/MainActivity.java
+++ b/app/src/main/java/com/adpth/bmicalculator/MainActivity.java
@@ -14,55 +14,38 @@ import android.widget.RelativeLayout;
import android.widget.SeekBar;
import android.widget.TextView;
+import com.adpth.bmicalculator.databinding.ActivityMainBinding;
+
public class MainActivity extends AppCompatActivity {
float height,weight;
-
- TextView height_txt,age;
-
int count_weight = 50,count_age = 19;
-
- RelativeLayout weight_plus, weight_minus, age_plus, age_minus;
-
boolean male_clk = true, female_clk = true, check1 = true, check2 = true;
+ private ActivityMainBinding binding;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
- setContentView(R.layout.activity_main);
+ binding = ActivityMainBinding.inflate(getLayoutInflater());
+ View view = binding.getRoot();
+ setContentView(view);
- height_txt = findViewById(R.id.height_txt);
-
- final TextView female_text = findViewById(R.id.female);
- final TextView male_text = findViewById(R.id.male);
-
- CardView card_female = findViewById(R.id.cardView_female);
- CardView card_male = findViewById(R.id.cardView_male);
-
- age_minus = findViewById(R.id.age_minus);
- age_plus = findViewById(R.id.age_plus);
-
- weight_minus = findViewById(R.id.weight_minus);
- weight_plus = findViewById(R.id.weight_plus);
-
- card_male.setOnClickListener(new View.OnClickListener() {
+ binding.cardViewMale.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
if (check1) {
if (male_clk) {
- male_text.setTextColor(Color.parseColor("#FFFFFF"));
- //male.setImageResource(R.drawable.male_white);
- male_text.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.male_white,0,0);
+ binding.male.setTextColor(Color.parseColor("#FFFFFF"));
+ binding.male.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.male_white,0,0);
male_clk = false;
check2 = false;
} else {
- male_text.setTextColor(Color.parseColor("#8D8E99"));
- //male.setImageResource(R.drawable.male);
- male_text.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.male,0,0);
+ binding.male.setTextColor(Color.parseColor("#8D8E99"));
+ binding.male.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.male,0,0);
male_clk = true;
check2 = true;
}
@@ -70,20 +53,20 @@ public class MainActivity extends AppCompatActivity {
}
});
- card_female.setOnClickListener(new View.OnClickListener() {
+ binding.cardViewFemale.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
if (check2) {
if (female_clk) {
- female_text.setTextColor(Color.parseColor("#FFFFFF"));
- female_text.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.female_white,0,0);
+ binding.female.setTextColor(Color.parseColor("#FFFFFF"));
+ binding.female.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.female_white,0,0);
female_clk = false;
check1 = false;
}
else {
- female_text.setTextColor(Color.parseColor("#8D8E99"));
- female_text.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.female,0,0);
+ binding.female.setTextColor(Color.parseColor("#8D8E99"));
+ binding.female.setCompoundDrawablesWithIntrinsicBounds(0,R.drawable.female,0,0);
female_clk = true;
check1 = true;
}
@@ -97,8 +80,7 @@ public class MainActivity extends AppCompatActivity {
CheckAge();
- Button calculate = findViewById(R.id.calculate);
- calculate.setOnClickListener(new View.OnClickListener() {
+ binding.calculate.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
CalculateBMI();
@@ -110,57 +92,52 @@ public class MainActivity extends AppCompatActivity {
private void CheckAge() {
- age = findViewById(R.id.age);
-
- age_plus.setOnClickListener(new View.OnClickListener() {
+ binding.agePlus.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
count_age++;
- age.setText(String.valueOf(count_age));
+ binding.age.setText(String.valueOf(count_age));
}
});
- age_minus.setOnClickListener(new View.OnClickListener() {
+ binding.ageMinus.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
count_age--;
- age.setText(String.valueOf(count_age));
+ binding.age.setText(String.valueOf(count_age));
}
});
}
private void CheckWeight() {
- final TextView weight_txt = findViewById(R.id.weight);
-
- weight_plus.setOnClickListener(new View.OnClickListener() {
+ binding.weightPlus.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
count_weight++;
- weight_txt.setText(String.valueOf(count_weight));
+ binding.weight.setText(String.valueOf(count_weight));
}
});
- weight_minus.setOnClickListener(new View.OnClickListener() {
+ binding.weightMinus.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
count_weight--;
- weight_txt.setText(String.valueOf(count_weight));
+ binding.weight.setText(String.valueOf(count_weight));
}
});
- weight = Float.parseFloat(weight_txt.getText().toString());
+ weight = Float.parseFloat(binding.weight.getText().toString());
}
private void CheckSeekbarStatus() {
- SeekBar Seekbar = findViewById(R.id.Seekbar);
- Seekbar.setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener() {
+ binding.Seekbar.setOnSeekBarChangeListener(new SeekBar.OnSeekBarChangeListener() {
@Override
public void onProgressChanged(SeekBar seekBar, int progress, boolean fromUser) {
String ht = progress + getResources().getString(R.string.cm);
- height_txt.setText(ht);
+ binding.heightTxt.setText(ht);
height = (float)(progress)/100;
}
@@ -181,7 +158,7 @@ public class MainActivity extends AppCompatActivity {
float BMI = weight / (height * height);
Intent intent = new Intent(MainActivity.this,ResultActivity.class);
intent.putExtra("BMI",BMI);
- intent.putExtra("age",age.getText().toString());
+ intent.putExtra("age",binding.age.getText().toString());
startActivity(intent);
}
}
\ No newline at end of file